Add allowed ip check #605
Merged
Add allowed ip check #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
reviewed
Dec 2, 2021
mtojek
reviewed
Dec 2, 2021
mtojek
reviewed
Dec 2, 2021
mtojek
reviewed
Dec 2, 2021
|
I think you have to update pipeline tests for the AWS test package. |
4 tasks
|
/test |
marc-gr
force-pushed
the
allowed-ip-check
branch
from
5c1a6d2
to
c96514e
Compare
Merged
efd6
reviewed
Dec 15, 2021
| func initializeAllowedIPsList() map[string]struct{} { | ||
| m := map[string]struct{}{ | ||
| "0.0.0.0": {}, "255.255.255.255": {}, | ||
| "0:0:0:0:0:0:0:0": {}, "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff": {}, |
There was a problem hiding this comment.
If this testing takes output from the net package, this should also probably have "::" since an IPv6 address renders as the abbreviation.
| } | ||
|
|
||
| if v.enabledAllowedIPCheck && !v.isAllowedIPValue(valStr) { | ||
| return fmt.Errorf("the IP %q is not one of the allowed test IPs", valStr) |
There was a problem hiding this comment.
It would be nice if this emitted a link to the list of acceptable IPs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To identify any IP in the testing value that is not in the supported Maxmind's allowed set (found here https://github.com/elastic/elastic-package/blob/master/docs/howto/ingest_geoip.md) a validation check is added at test time.
Will output something similar to